Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http1 StreamConfig配置的max_header_size无法生效 #2328

Open
yejialiango opened this issue Jun 7, 2023 · 2 comments
Open

Http1 StreamConfig配置的max_header_size无法生效 #2328

yejialiango opened this issue Jun 7, 2023 · 2 comments
Assignees

Comments

@yejialiango
Copy link
Contributor

Describe the bug

pkg/stream/http/stream.go:252
pkg/stream/http/stream.go:750
pkg/filter/network/proxy/factory.go:80

这里ok肯定是等于fasle的,因为streamConfigHandler最终是转成StreamConfig而不是map
image

所以无法成功设置max_header_size,这里是不是直接用parseStreamConfig取值就好了?

image

Expected behavior

Actual behavior

Steps to reproduce

Minimal yet complete reproducer code (or GitHub URL to code)

Environment

  • MOSN Version
@doujiang24
Copy link
Member

感谢报告,欢迎 PR~ 记得带测试用例~

@yejialiango
Copy link
Contributor Author

ok~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants