-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color picker popover to ColorInput #910
Comments
I'll look into that. I guess the new |
Does it have to be the same layout as in Blender, i.e. one (circular) map for hue and saturation and another one for brightness, or would you also be fine with one map for saturation and brightness and another linear one for hue (as in the gif I sent)? I think the latter would be easier to implement and I like the easy way of keeping the saturation and brightness while playing around with the hue, but I guess that comes down to personal preference. |
Yes, the square + hue slider from the gif is better. It's common in most drawing software so I think it would be a good default. |
I had some other things going on but I finally got to work on it again. The functionality is there now but before spending time on styling I wanted to clarify how exactly you imagine the component to look like. That's the current (temporary) state: Some feedback would be great @aarthificial ! |
Great, got everything looking good now. Just one more thing, where do you want the popover to be located relative to the color preview? Just some fixed distance to the right? If it just opens where the click happens, the background blends with the rest of the settings pane. |
Description
Add a color picker popover to the existing
ColorInput
component. One could then select a color with instant visual feedback instead of having to type the color explicitly, which I think is way more convenient.Proposed solution
The picker could open when the
ColorPreview
component inside theColorInput
is clicked.I looked for existing solutions and found react-colorful, which I think looks promising.
The text was updated successfully, but these errors were encountered: