Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Vite V5 #923

Open
navjotahuja92 opened this issue Jan 15, 2024 · 1 comment
Open

Upgrade to Vite V5 #923

navjotahuja92 opened this issue Jan 15, 2024 · 1 comment
Labels
b-breaking Breaking change for the next major release c-accepted The issue is ready to be worked on
Milestone

Comments

@navjotahuja92
Copy link

Description
Should we upgrade to Vite v5? Maybe vitest too?
I need to use the package in one of the mono repo which only supports v5

Proposed solution
Update files:
package.json
packages/core/package.json
packages/create/template-2d-js/package.json
packages/create/template-2d-ts/package.json
packages/vite-plugin/package.json
packages/e2e/package.json

Considered alternatives
...

Additional context
...

@navjotahuja92 navjotahuja92 added the b-enhancement New feature or request label Jan 15, 2024
@aarthificial
Copy link
Contributor

The only thing in this mono repo that depends on vite is vite-plugin and it's already compatible with 5.x:

"peerDependencies": {
"vite": "4.x || 5.x"
},

You can simply update Vite after bootstraping a new project and it should work just fine.

We won't be updating our internal dependencies to 5.x until Motion Canvas 4 because our packages need to be properly configured to use es module which will be a breaking change.

@aarthificial aarthificial removed their assignment Jan 16, 2024
@aarthificial aarthificial added c-accepted The issue is ready to be worked on b-breaking Breaking change for the next major release and removed b-enhancement New feature or request labels Jan 16, 2024
@aarthificial aarthificial added this to the v4 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b-breaking Breaking change for the next major release c-accepted The issue is ready to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants