Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkIdentifier is missing in generated Model Design for DI model #629

Open
mpostol opened this issue Aug 15, 2021 · 2 comments
Open

NetworkIdentifier is missing in generated Model Design for DI model #629

mpostol opened this issue Aug 15, 2021 · 2 comments
Assignees
@mpostol
Labels
Bug Bug in the code.
Projects
Information Model Validation (IMV)
Milestone
SemanticData_6.X

Comments

@mpostol
Copy link
Owner

mpostol commented Aug 15, 2021

Copy of the mpostol/UA-Nodeset#51
@mpostol mpostol added the Bug Bug in the code. label Aug 15, 2021
@mpostol mpostol self-assigned this Aug 15, 2021
@mpostol mpostol added this to Needs triage in Information Model Validation (IMV) via automation Aug 15, 2021
@mpostol mpostol added this to the SemanticData_6.X milestone Aug 15, 2021
@mpostol mpostol moved this from Needs triage to High priority in Information Model Validation (IMV) Aug 15, 2021
mpostol added a commit that referenced this issue Aug 15, 2021
@mpostol
NetworkIdentifier is missing in generated Model Design for DI model #629
3ec08b8 


- marked affected code
@mpostol mpostol mentioned this issue Aug 16, 2021
Open
@mpostol mpostol moved this from High priority to Low priority in Information Model Validation (IMV) Feb 7, 2022
@mpostol mpostol moved this from Low priority to High priority in Information Model Validation (IMV) Mar 9, 2022
@mpostol
Copy link
Owner Author

mpostol commented Mar 9, 2022

The commit 3ec08b8 causes unhandled exception in many models including but not limited to DI

mpostol added a commit that referenced this issue Mar 9, 2022
@mpostol
NetworkIdentifier is missing in generated Model Design for DI model #629
b64d3ef 


- fixed anchor id - unimportant changes
mpostol added a commit that referenced this issue Mar 9, 2022
@mpostol
NetworkIdentifier is missing in generated Model Design for DI model #629
247892e 


- removed exception thrown while unsupported reference is encountered
mpostol added a commit that referenced this issue Mar 12, 2022
@mpostol
NetworkIdentifier is missing in generated Model Design for DI model #629
289b75b
mpostol added a commit that referenced this issue Mar 12, 2022
@mpostol
NetworkIdentifier is missing in generated Model Design for DI model #629
9b6880a 


- fixed AddressSpaceContextImportUANodeSetNull UT
mpostol added a commit that referenced this issue Mar 12, 2022
@mpostol
NetworkIdentifier is missing in generated Model Design for DI model #629
910d1cd 


- improved CalculateNodeReferencesNullUANodeTest
mpostol added a commit that referenced this issue Mar 13, 2022
@mpostol
NetworkIdentifier is missing in generated Model Design for DI model #629
8adb673 


- improved UT to investigate the problem
- improved code to figure how to fix this problem
= UT 👍
@mpostol
Copy link
Owner Author

mpostol commented Mar 16, 2022 •
edited

Problems to fix:

  • new nodes added in the second circle are duplicated
  • StateNumber variable is not generated and no warning added to the log
  • Some references have the wrong target (circular references); DeviceSet should point to DeviceFeatures in case IsInverse="true"
  • the model contains 0 nodes and no errors/warnings reported

mpostol added a commit that referenced this issue Mar 16, 2022
@mpostol
NetworkIdentifier is missing in generated Model Design for DI model #629
045b62d 


- Development in progress
mpostol added a commit that referenced this issue Mar 16, 2022
@mpostol
NetworkIdentifier is missing in generated Model Design for DI model #629
02b1837 


- the model contains 0 nodes and no errors/warnings reported
mpostol added a commit that referenced this issue Mar 17, 2022
@mpostol
NetworkIdentifier is missing in generated Model Design for DI model #629
34ee3b8 


- fixes #651
- UT must be fixed - nodes could be duplicated if they are the target of 2+ references
mpostol added a commit that referenced this issue Mar 19, 2022
@mpostol
NetworkIdentifier is missing in generated Model Design for DI model #629
cf577b6 


- Development in progress - refactoring code to prepare it for future changes
@mpostol mpostol mentioned this issue Mar 19, 2022
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpostol mpostol

Labels
Bug Bug in the code.
Projects
Information Model Validation (IMV)
High priority
Milestone
SemanticData_6.X
Development

No branches or pull requests
1 participant
@mpostol