Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace github actions' windows runner with docker teamcity windows/amd64 agent (like others) #3348

Open
1 task done
JeViCo opened this issue Mar 20, 2024 · 0 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@JeViCo
Copy link

JeViCo commented Mar 20, 2024

Is your feature request related to a problem? Please describe.

Windows runner is the only part of CI that is heavily dependent on github actions. It should be more flexible

Pros:

  • Additional way of building MTA client using Docker
  • Ability to replicate MTA CI completely on other platforms like gitlab and bitbucket
  • No global changes required, everything stays (except one minor thing in additional context)
    Cons:
  • Current CI pipeline should be edited
  • Still platform-dependent. Windows can run both windows & linux containers but linux is not

Describe the solution you'd like

Create docker runner based on jetbrains/teamcity-agent or jetbrains/teamcity-agent:latest-windowsservercore and integrate with current MTA CI. It should install visual studio and all related requirements by using vs_buildtools or choco.

Describe alternatives you've considered

I've recently tested docker-based MTA client builder with mcr.microsoft.com/windows/servercore:ltsc2022 image and it works like a charm. Since MTA use teamcity CI, we should consider using their docker agents

Additional context

The only thing that should be fixed is vswhere tool not detecting MSBuild component when using vs_buildtools installer. Following part of win-build.bat file:
%VSWHERE% -latest -requires Microsoft.Component.MSBuild
should be replaced with:
%VSWHERE% -latest -products * -requires Microsoft.Component.MSBuild

Security Policy

  • I have read and understood the Security Policy and this issue is not about a cheat or security vulnerability.
@JeViCo JeViCo added the enhancement New feature or request label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant