Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMG files are not properly unloaded after resource stopped #3062

Closed
1 task done
Xenius97 opened this issue Jun 10, 2023 · 6 comments · Fixed by #3063 or #3367
Closed
1 task done

IMG files are not properly unloaded after resource stopped #3062

Xenius97 opened this issue Jun 10, 2023 · 6 comments · Fixed by #3063 or #3367
Assignees
@TheNormalnij
Labels
bug Something isn't working
Milestone
1.6.0

Comments

@Xenius97
Copy link
Contributor

Xenius97 commented Jun 10, 2023 •
edited

Describe the bug

If you stop the resource, and try to modify file with script or program you will get an error message another program is using it.

Steps to reproduce

load img, then stop the resource

this should fix it, but does currently nothing:

addEventHandler("onClientResourceStop", resourceRoot, function()
	if img then
		engineRemoveImage(img)
	end
end)

Version

Multi Theft Auto v1.6-release-21834

Additional context

No response

Relevant log output

No response

Security Policy

  • I have read and understood the Security Policy and this issue is not security related.
@Xenius97 Xenius97 added the bug Something isn't working label Jun 10, 2023
@TheNormalnij TheNormalnij self-assigned this Jun 11, 2023
TheNormalnij added a commit to TheNormalnij/mtasa-blue that referenced this issue Jun 11, 2023
@TheNormalnij
Fix missing file close call during IMG unloading. multitheftauto#3062
98daf0e
@TheNormalnij TheNormalnij mentioned this issue Jun 11, 2023
Merged
patrikjuvonen pushed a commit that referenced this issue Jun 11, 2023
@TheNormalnij
Fix #3062: Fix missing file close call during IMG unloading (#3063)
1c277b5
@patrikjuvonen patrikjuvonen added this to the 1.6.0 milestone Jun 11, 2023
@Xenius97
Copy link
Contributor Author

Still an issue, not fixed, please can you reopen?

@TheNormalnij
Copy link
Contributor

Same WTR?

@Xenius97
Copy link
Contributor Author

img files are protected after disconnect/resource stop, if u restart the resource you will get a kick by HTTP server file mismatch or script will fail to load, cannot modify/delete file until MTA gets stopped

@Pirulax
Copy link
Contributor

Pirulax commented Jan 17, 2024 •
edited

@TheNormalnij Is it possible that the CClientIMGManager or CCLientIMG isn't destroyed?
Remember that we have an open file for reading the img.
Perhaps we should close it? And reopen each time the user wants to get a file's content?

@Xenius97
Copy link
Contributor Author

[2024-01-17 16:27:29] WARNING: [mods]\exs_modloader\modloader_c.lua:58: Operation failed @ 'fileDelete' [@cache//_cache_269203]

@Xenius97
Copy link
Contributor Author

Still an issue, not fixed yet.

[2024-04-16 10:05:46] WARNING: [mods]\ez_modloader\client\main.lua:58: Operation failed @ 'fileDelete' [@cache//_cache_398908]
[2024-04-16 10:05:46] WARNING: [mods]\ez_modloader\client\main.lua:58: Operation failed @ 'fileDelete' [@cache//_cache_381833]

@TheNormalnij TheNormalnij reopened this Apr 17, 2024
@TheNormalnij TheNormalnij mentioned this issue Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheNormalnij TheNormalnij

Labels
bug Something isn't working
Projects
None yet
Milestone
1.6.0
4 participants
@Xenius97 @TheNormalnij @Pirulax @patrikjuvonen