Add the possibility to cancel onPedDamage event - QOL feature

[TracerDS]

Is your feature request related to a problem? Please describe.

Right now to cancel ped's damage you have to use onClientPedDamage or do an extensive check with onPedWasted + setElementHealth.
Cancelling the event will be a very good QOL feature.

Describe the solution you'd like

Be able to cancel onPedDamage event

Describe alternatives you've considered

No response

Additional context

No response

Security Policy

• I have read and understood the Security Policy and this issue is not about a cheat or security vulnerability.

[FileEX]

Damage Handler is located on the client side and this is where the onClientPedDamage event is sent and, depending on its status, the handler returns the result.

The server-side event works based on the synchronization packet, where the amount of HP is compared between packets. I think a reasonable solution would be to set the HP amount to something like "current HP + loss" if the event was canceled.

However, I don't know what happens when the ped/player dies? Then, despite the event being canceled, onPedWasted will be sent + the invicible bug will probably appear (#414 )

[TracerDS]

Damage Handler is located on the client side and this is where the onClientPedDamage event is sent and, depending on its status, the handler returns the result.

The server-side event works based on the synchronization packet, where the amount of HP is compared between packets. I think a reasonable solution would be to set the HP amount to something like "current HP + loss" if the event was canceled.

if the server sends packets to the client about ped damage then cancelEvent should not send any synchronization packets and ignore everything. At least thats how I would see it to be the most reasonable and performant solution

However, I don't know what happens when the ped/player dies? Then, despite the event being canceled, onPedWasted will be sent + the invicible bug will probably appear (#414 )

Yeah we would need to check if loss >= currentHP and not run onPedWasted if the event was cancelled and ped died

I tried to implement it but its a lot of complicated work

[FileEX]

if the server sends packets to the client about ped damage then cancelEvent should not send any synchronization packets and ignore everything. At least thats how I would see it to be the most reasonable and performant solution

We can't stop sending the sync packet and ignore everything. These packets concern general data synchronization between clients and the server, not just health. Canceling the sending of synchronization packets after canceling the event will cause desynchronization bugs

[TracerDS]

if the server sends packets to the client about ped damage then cancelEvent should not send any synchronization packets and ignore everything. At least thats how I would see it to be the most reasonable and performant solution

We can't stop sending the sync packet and ignore everything. These packets concern general data synchronization between clients and the server, not just health. Canceling the sending of synchronization packets after canceling the event will cause desynchronization bugs

If its about health only then how would that cause desync with other players? For other ped related packets, sure. However if we are cancelling the damage event then only the packets responsible for ped's health should be ignored

[FileEX]

The sync packet covers a lot of information, not just health, so you can't just cancel it

mtasa-blue/Server/mods/deathmatch/logic/CPedSync.cpp

Lines 245 to 264 in 1f2c6e7

	if (Data.ucFlags & 0x08)
	{
	// Less health than last time?
	float fPreviousHealth = pPed->GetHealth();
	pPed->SetHealth(Data.fHealth);
	if (Data.fHealth < fPreviousHealth)
	{
	// Grab the delta health
	float fDeltaHealth = fPreviousHealth - Data.fHealth;
	if (fDeltaHealth > 0.0f)
	{
	// Call the onPedDamage event
	CLuaArguments Arguments;
	Arguments.PushNumber(fDeltaHealth);
	pPed->CallEvent("onPedDamage", Arguments);
	}
	}
	}