Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltips to all icon controls #411

Open
FreekVR opened this issue Jan 4, 2023 · 3 comments
Open

Add tooltips to all icon controls #411

FreekVR opened this issue Jan 4, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@FreekVR
Copy link

FreekVR commented Jan 4, 2023

It would be great if media-chrome would ship with a default implementation of tooltips for all of the iconography used for controls.

This could either be a default Browser Chrome implementation (using title=foo attributes) or a custom tooltip.

Some examples of what I mean;

Youtube
image

Vimeo
image

I think this would greatly help some less digital-savvy visitors with understanding how to use players built with media-chrome.

@luwes luwes added the enhancement New feature or request label Jan 4, 2023
@gkatsev
Copy link
Contributor

gkatsev commented Jan 4, 2023

Having tooltips would be great. I'd say we should be a bit wary of using the title attribute because that has implications for Screen Readers and we don't want to double announce buttons.

@heff
Copy link
Collaborator

heff commented Jan 9, 2023

This is definitely a missing feature. I think the Mux team has our hands full for the next few months, so if anyone else wants to try a proof-of-concept, have at it.

@luwes
Copy link
Contributor

luwes commented Feb 18, 2024

A tooltip, how hard can it be :). Seen 3 different ways to declare it so far:

I think maybe a combination of the last 2. start with just needing to add an attribute for a tooltip, a slotted child if needing more styling etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants