Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate subcommand only accounts for author's OS with only_os #88

Open
TUSF opened this issue Jan 2, 2023 · 2 comments
Open

generate subcommand only accounts for author's OS with only_os #88

TUSF opened this issue Jan 2, 2023 · 2 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@TUSF
Copy link

TUSF commented Jan 2, 2023

In my zigmod.yml, I have:

dependencies:
  - {
    src: git https://github.com/marlersoft/zigwin32,
    only_os: windows
  }
  - {
    src: system_lib dwrite,
    only_os: windows
  }

This works well enough when using the fetch subcommand, but if I use the generate subcommand, the generated deps.zig file will assume whoever is building the package is on the same OS as whoever ran zigmod generate.

This makes generate no different from fetch for libraries depending on OS-specific libraries & APIs.

@nektro
Copy link
Owner

nektro commented Jan 3, 2023

this would require quite a rework of how the command currently works and is a known limitation. given that upstream work on the native package manager is now underway this is unlikely to get fixed in zigmod but ill leave this open in case i get a lightbulb of inspiration

@nektro nektro added enhancement New feature or request wontfix This will not be worked on labels Jan 3, 2023
@TUSF
Copy link
Author

TUSF commented Jan 3, 2023

Understandable. Does seem like it might turn out to be a lot of work for something that might end up obsolete pretty soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants