Fixes #555 Structuring nested object causes DataException #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conker84
reviewed
Mar 10, 2023
There was a problem hiding this comment.
Hi @ogawa-takeshi thanks for the contribution, please see my comment
Comment on lines
+286
to
+295
| | { | ||
| | key1: { | ||
| | subKey1: "value", | ||
| | subKey2: "value" | ||
| | }, | ||
| | key2: { | ||
| | subKey1: "value", | ||
| | subKey2: true | ||
| | } | ||
| | } AS nested, |
There was a problem hiding this comment.
I think there is a misunderstanding a Map can have only values of the same simple type, like for instanceMap<String, Integer> or Map<String, String>.
The structure that you are expressing here is not a Map, but a Struct.
|
I'm closing this for lack of feedback. Feel free to re-open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #555