-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database
was removed from neomodel.util
and moved into neomodel.sync_.core
#793
Comments
Hello ! So.... That is a problem with the current versioning scheme of neomodel. The choice was made originally to make the versioning not fully semantic, but rather : So technically, 5.3.0 IS a major release according to this scheme. Sorry if you were not aware and it broke your application ; I thought long and hard about moving to a real semantic versioning now but in the end did not. Now it makes me doubt my choice again 😓 . I did write in the README that 5.3.0 would be a breaking change-introducing release some months ago though - but I know this is a limited option. As for the |
Database
was removed from neomodel.util
Database
was removed from neomodel.util
and moved into neomodel.sync_.core
(Note : I took the liberty to update your issue's title, so that people can see the fix straight away) |
Thanks for the quick reply and for the suggested fix; we're fine now but it was quite a surprise this morning! 😁
I slightly disagree with this approach though, because of the way most package managers handle version pinning and how most people are used to pin versions in their requirements files. I would suggest either not introducing breaking changes for SemVer minor versions, or specify this in the documentation, so people can use tilde requirements for For now we'll just pin this to Thanks! (This is also a quirk of python's lack of |
Totally agree with you ; I have gone through the documentation again, trying to find where the versioning scheme was explained and... You're right, it's not in there. So that is definitely something we have to add. Maybe we will go away from pinning Neo4j version as the first digit in the future ; it's a tough call, because also the scheme today shows you right away which version of Neo4j is supported. Let's see ! I will leave your Issue open for a few days still, so any people coming can see this if they're wondering. |
Expected Behavior (Mandatory)
The following python command, which worked in 5.2.1, should also work in 5.3.0:
There should not be any breaking changes for minor version updates. As we use typed python, this has rendered our applications to fail running after a
poetry update
!Also this breaking change is not specified in your changelog/readme, we had to check your source code to find out what was happening.
Actual Behavior (Mandatory)
How to Reproduce the Problem
neomodel = "5.2.1"
neomodel = "^5.2.1"
)poetry update
or equivalentneomodel = 5.3.0
should be installedSimple Example
Screenshots (where it's possibile)
Specifications (Mandatory)
Currently used versions
Versions
The text was updated successfully, but these errors were encountered: