Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline renders way too low #2561

Closed
AThePeanut4 opened this issue May 18, 2024 · 0 comments · Fixed by #2564
Closed

Underline renders way too low #2561

AThePeanut4 opened this issue May 18, 2024 · 0 comments · Fixed by #2564
Labels
bug Something isn't working

Comments

@AThePeanut4
Copy link
Contributor

AThePeanut4 commented May 18, 2024

Describe the bug
The underline underneath underlined text renders way too low, to the point of being inside the cell below.

To Reproduce
Steps to reproduce the behavior:
View any underlined text - easiest is probably to open the README in the neovide repo.

The font I'm using is JetBrains Mono @ 11.2pt, but it seems to be happening to some extent with any font and at any font size.
This is my config.toml:

[font]
normal = ["JetBrains Mono", "JetBrainsMono NF"]
size = 11.2
# needed after #2500, to keep the same spacing (i.e. only in the last screenshot)
width = -0.44

I did a git bisect, which found 6b04db5 (#2484) to be the offending commit.

Screenshots

These screenshots are on macOS, but I'm getting the same issue on Linux.

On f9848f0
f9848f0
On 6b04db5
6b04db5
On latest commit (818ff73, v0.13.0)
818ff73

Desktop (please complete the following information):

  • OS: macOS 14.4.1, Arch Linux
  • Neovide Version 0.13.0
  • Neovim Version 0.10.0

Please run neovide --log and paste the contents of the .log file created in the current directory here:

neovide_rCURRENT.log

@AThePeanut4 AThePeanut4 added the bug Something isn't working label May 18, 2024
@AThePeanut4 AThePeanut4 changed the title Underline renders way too low on macOS Underline renders way too low May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant