Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize Multi Word Filters #16104

Open
mr1716 opened this issue May 13, 2024 · 3 comments · May be fixed by #16230
Open

Capitalize Multi Word Filters #16104

mr1716 opened this issue May 13, 2024 · 3 comments · May be fixed by #16230
Assignees
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@mr1716
Copy link

mr1716 commented May 13, 2024

NetBox version

v4.0.1

Feature type

Change to existing functionality

Proposed functionality

Currently, in the User Interface, the models have Filter forms that are multi-word that are named like "Site group" but for the Side Navigation, multi word labels are capitalized to "Site Groups." This request is to ensure consistency in the filters.

Use case

It would ensure consistent grammar without breaking any functionality. It's a minor change, but improves readability and ensures consistency throughout the entire program. Thus improving the user experience

Database changes

No response

External dependencies

No response

@mr1716 mr1716 added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels May 13, 2024
@mr1716
Copy link
Author

mr1716 commented May 13, 2024

And then there are some filtersets like the photo below, where multi word filters are both capitalized and not capitalized. This consistency is not an ideal look and should be improved.
image

If needed, I can try to take a shot at fixing this.

@arthanson arthanson added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels May 13, 2024
@arthanson arthanson removed their assignment May 13, 2024
@mr1716
Copy link
Author

mr1716 commented May 13, 2024

@arthanson I took a shot at fixing the issue. Not sure what it would take for a review, since I'm new here.

@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 14, 2024
@mr1716
Copy link
Author

mr1716 commented May 16, 2024

@abhi1693, looks like I may not be the best developer to handle this. It should be handled by someone more familiar with Netbox

@DanSheps DanSheps assigned danner26 and unassigned mr1716 May 20, 2024
danner26 added a commit to danner26/netbox that referenced this issue May 20, 2024
@jeremystretch jeremystretch added the complexity: low Requires minimal effort to implement label May 21, 2024
@mr1716 mr1716 linked a pull request May 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
5 participants