Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Link Icons #16178

Open
hendrikbl opened this issue May 17, 2024 · 3 comments
Open

Custom Link Icons #16178

hendrikbl opened this issue May 17, 2024 · 3 comments
Labels
complexity: high Expected to require a large amont of time and effort to implement relative to other tasks status: under review Further discussion is needed to determine this issue's scope and/or implementation type: feature Introduction of new functionality to the application

Comments

@hendrikbl
Copy link

NetBox version

v4.0.2

Feature type

Change to existing functionality

Proposed functionality

The ability to add an optional icon to custom links to visually improve the rendered buttons. Either by providing a selection of available mdi icons or by providing a text field where users can input the name of the mdi icon. By making this field optional we do not create any breaking changes to existing custom links.

Use case

Having icons in buttons created by custom links would lead to a quicker recognition of the links purpose. E.g. mdi-web could be used with a link that opens an ip in your web browser.
Also almost every button in netbox uses an icon so having this option for custom links would make them fit better into the overall visual experience.

Database changes

The CustomLink model needs an additional field (e.g. button_icon) to store the icon.

External dependencies

None
@hendrikbl hendrikbl added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels May 17, 2024
@alehaa
Copy link
Contributor

alehaa commented May 18, 2024

seems to be a duplicate of #6877. FYI: The workaround using an <i> doesnt work anymore but you can use <div class="d-inline"> instead.

@hendrikbl
Copy link
Author

Oh you're right, sorry for the duplicate. We had the <i> solution before.
I will try your's asap.

@DanSheps
Copy link
Member

Going to need to look into this a little more to see if it is a netbox thing or a HTML/CSS framework thing.

@DanSheps DanSheps added status: under review Further discussion is needed to determine this issue's scope and/or implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels May 20, 2024
@jeremystretch jeremystretch added the complexity: high Expected to require a large amont of time and effort to implement relative to other tasks label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity: high Expected to require a large amont of time and effort to implement relative to other tasks status: under review Further discussion is needed to determine this issue's scope and/or implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alehaa @hendrikbl @DanSheps @jeremystretch