Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifier-key detection only works for Windows and macOS #95

Open
aried3r opened this issue Jan 21, 2020 · 1 comment
Open

Modifier-key detection only works for Windows and macOS #95

aried3r opened this issue Jan 21, 2020 · 1 comment

Comments

@aried3r
Copy link

aried3r commented Jan 21, 2020

Hey!

I believe this check
https://github.com/nib-edit/Nib/blob/8cc08f1b9e41c8bec5b6e170f9fc05ec60dee4f1/packages/core/src/utils/format-keymap.js#L9
should probably be the inverse, if it's a Mac, the cmd key symbol should be shown, otherwise a circumflex or Ctrl. This also covers all other OS', since macOS is the only one with a cmd key I believe.

On mobile, I'd leave out the shortcuts completely, but I'm not sure how feasible detection is, especially that the iPad Pro keyboard has a command key.

WDYT?

@jpuri
Copy link
Member

jpuri commented Jan 22, 2020

This definitely can be improved, I will take time to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants