Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dep keyword for importing from dependencies #2307

Open
jfecher opened this issue Aug 14, 2023 · 2 comments · May be fixed by #4946
Open

Remove dep keyword for importing from dependencies #2307

jfecher opened this issue Aug 14, 2023 · 2 comments · May be fixed by #4946
Assignees
@michaeljklein
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Aug 14, 2023

Problem

Importing from libraries in Noir differs from rust in that you must add a dep:: prefix to each path in the dependency. This is unnecessary since you can already tell by the crate name in the path that it is a different crate.

Happy Case

The dep:: prefix is removed.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@jfecher jfecher added enhancement New feature or request P-LOW labels Aug 14, 2023
@jfecher jfecher self-assigned this Aug 14, 2023
@kevaundray
Copy link
Collaborator

@jfecher did you start working on this? If not, then I think we can assign it to someone else to reduce context switch and since its E-LOW

@jfecher
Copy link
Contributor Author

jfecher commented Aug 17, 2023

@kevaundray I haven't

@TomAFrench TomAFrench assigned michaeljklein and unassigned jfecher Apr 21, 2024
@michaeljklein michaeljklein linked a pull request Apr 30, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaeljklein michaeljklein

Labels
enhancement New feature or request
Projects
Noir
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: remove dep:: prefix noir-lang/noir
4 participants
@michaeljklein @jfecher @kevaundray @Savio-Sou