Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Slice to List #5022

Open
marekkirejczyk opened this issue May 13, 2024 · 0 comments
Open

Rename Slice to List #5022

marekkirejczyk opened this issue May 13, 2024 · 0 comments
Labels
discussion enhancement New feature or request

Comments

@marekkirejczyk
Copy link

Problem

We are implementing a structure which holds a dynamically-sized view into an array (i.e. array, offset and length). Analogous to slice in Rust, with very similar properties. We can't name it slice as there is already a type called slice in Noir.

Happy Case

It seems, slice in Noir is closer to a list than a slice in Rust.
It has cheap operations of adding elements at the beginning, end and in the middle.
The name is therefore a bit misleading.
Hence, we would propose to use name List for it and make a room for Slice.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

Alternatively, we could extend slice to match Fragment functionality.

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@marekkirejczyk marekkirejczyk added the enhancement New feature or request label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants