Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug Report: step conditions not working with push webhook provider #5548

Open
2 tasks done
jainpawan21 opened this issue May 12, 2024 · 1 comment
Open
2 tasks done
Labels
bug Something isn't working linear

Comments

@jainpawan21
Copy link
Member

jainpawan21 commented May 12, 2024

馃摐 Description

Novu supports adding multiple integrations of same provider. Each integration can have step conditions on tenants and based on these conditions, these providers can be used in workflow execution.

馃憻 Reproduction steps

  1. Create two push webhook integrations, give different webhook URL and secret hmac key. Give different names to each one to make it easy to identify later. Make these two integrations active
  2. Create a subscriber push-webhook-subscriber for testing this bug
  3. Update the above subscriber's credentials using this API for both of the integrations. Use any string value for device token
  4. Create a workflow with only push step. write title and message content.
  5. make sure only above two push webhook integrations are active for push channel providers
  6. Create two tenants with different name and identifier. Store this data
// for first tenant
{
  "country": "US"
}

// for second tenant
{
  "country": "EU"
}
  1. Add conditions on tenants for data.country key on both integrations
Screenshot 2024-05-12 at 3 25 10鈥疨M Screenshot 2024-05-12 at 3 25 25鈥疨M
  1. Trigger the workflow to push-webhook-subscriber subscriber and send tenant identifier also
  2. Push step will be executed for both providers and conditions will not take effect

馃憤 Expected behavior

tenants conditions should take effect and integration should be disabled based on conditions

馃憥 Actual Behavior with Screenshots

Tenants conditions are not working
Screenshot 2024-05-12 at 3 30 12鈥疨M

Novu version

Novu SaaS

npm version

No response

node version

No response

馃搩 Provide any additional context for the Bug.

transactionId: - b67f3197-f0b5-4ea5-9603-f82d332cc3c1

馃憖 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find a similar issue

馃彚 Have you read the Contributing Guidelines?

Are you willing to submit PR?

None

@jainpawan21 jainpawan21 added bug Something isn't working linear labels May 12, 2024
Copy link

linear bot commented May 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linear
Projects
None yet
Development

No branches or pull requests

1 participant