Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] useLoadingIndicator error #27175

Closed
3 of 4 tasks
dethdkn opened this issue May 12, 2024 · 3 comments · Fixed by #27176
Closed
3 of 4 tasks

[feat] useLoadingIndicator error #27175

dethdkn opened this issue May 12, 2024 · 3 comments · Fixed by #27176

Comments

@dethdkn
Copy link
Contributor

dethdkn commented May 12, 2024

Describe the feature

When calling finish() from useLoadingIndicator, it would be nice to have a error param to show a red (or any other color) loading bar

example:
loading

Additional information

  • Would you be willing to help implement this feature?
  • Could this feature be implemented as a module?

Final checks

@H0onnn
Copy link

H0onnn commented May 13, 2024

@huang-julien Hello ! Can I solve this problem ?

@dethdkn
Copy link
Contributor Author

dethdkn commented May 13, 2024

Hello @H0onnn I've actually already submitted a pull request to address it. I would really appreciate it if you could take a look at my code and provide any feedback or improvements you might have in mind.

#27176

@H0onnn
Copy link

H0onnn commented May 14, 2024

@dethdkn good ! Thank you for the great job you've done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants