Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of the UIGraphicsBeginImageContextWithOptions in Xcode15 #2200

Open
3 tasks done
iPHYZLL opened this issue Jan 22, 2024 · 1 comment
Open
3 tasks done

Comments

@iPHYZLL
Copy link

iPHYZLL commented Jan 22, 2024

Issue is for reporting a problem of Kingfisher. To ask a question or discuss about usage, please go to the Discussion (https://github.com/onevcat/Kingfisher/discussions).

  • Was thinking whether or not I should open a discussion instead, but I think this is more of an issue (potential) itself.

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

Issue Description

Building with Xcode 15 for iOS 17 might lead to the run-time crash when using a deprecated UIGraphicsBeginImageContextWithOptions code on the UIImage instances with .zero size.

"Duplicate thread":
#2176

Solution
DylanVann/react-native-fast-image#1010

What

I can see that GraphicsContext.begin(size: CGSize, scale: CGFloat) still uses a deprecated UIGraphicsBeginImageContextWithOptions call on 2 places (ImageDrawing).

This is still the case as of today (22.1.2024), on the latest version of the library (master).

Other Comment

We did not experience any issues (as we don't use blurred images on our projects), but we are just wondering if there are any updates planned for the upcoming releases of the lib, where the deprecated code will be replaced?

@Changzw
Copy link

Changzw commented Apr 9, 2024

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants