Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python version constraints could lead to breaking dependency resolution #1459

Open
m-martin-j opened this issue Nov 24, 2023 · 2 comments
Open

Comments

@m-martin-j
Copy link

Versions

river version: ^0.20.0
Python version: > 3.13
Operating system: any

Describe the bug

Is there any specific reason, why the maximally allowed Python version is limited to 3.13 from 0.20.0 releases of river?

python = ">=3.9,<3.13"

I guess that this breaks dependency resolution for a fair portion of projects out there specifying their Python version as e.g. ^3.11, which is quite common. At least, this contradicts what is noted in the readme. (There, we should also correct the minimally required version from 3.8 to 3.9 to correspond what is required by the build system.)

river/README.md

Line 106 in 7b2f1b8

River is intended to work with **Python 3.8 and above**. Installation can be done with `pip`:

Steps/code to reproduce

The problem primarily concerns dependency resolution.

@m-martin-j
Copy link
Author

A follow-up: After researching more, I understand that this point is heavily opinionated.

The capping is also done in scipy (scipy/scipy#17957). Numpy seemed to have resolved by removing the upper bound (numpy/numpy#24962) after some discussions (numpy/numpy#24810).

@MaxHalford
Copy link
Member

Hey @m-martin-j. Indeed, I can't remove this we depend on SciPy. Thanks for providing context. Maybe we can leave this issue open until SciPy changes something on their side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants