Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide .msi package in releases #1519

Closed
1 of 2 tasks
johnd0e opened this issue May 7, 2024 · 1 comment
Closed
1 of 2 tasks

Provide .msi package in releases #1519

johnd0e opened this issue May 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@johnd0e
Copy link

johnd0e commented May 7, 2024

Search before asking

  • issues 中没有找到类似的内容。
    I searched in the issues and found nothing similar.

feature

.msi is useful e.g. for automation

描述 Motivation

.msi package was included in Releases up to v0.3.51, that it disappeared without explanation.
I wonder if it is bug or intended action.

Solution

No response

还有其他内容吗?Anything else?

No response

你是否愿意提交一份 PR?Are you willing to submit a PR?

  • 我愿意提供 PR! I'm willing to submit a PR!
@johnd0e johnd0e added the enhancement New feature or request label May 7, 2024
@yetone
Copy link
Collaborator

yetone commented May 8, 2024

This is the reason why .msi is no longer provided:

Firstly, I wrote "all" in the bundle.targets of my tauri.conf.json, which led it to build both wix installer (.msi) and nsis installer (-setup.exe). However, the default configuration of updaterJsonPreferNsis in Tauri's official github action tauri-apps/tauri-action@v0 is false (resulting in the generated updater json containing msi package), so users who installed with -setup.exe can never update successfully. Plus, recently Tauri's packaged .msi always lacks files and gets falsely reported by Windows Defender. But there are no issues with -setup.exe, so I completely abandoned .msi and only packaged -setup.exe.

Pitfalls:

  1. I packaged both .msi and -setup.exe, which can easily be mixed up.
  2. The default in Tauri's official action is .msi for updater json but they mentioned changing it to default -setup.exe for Tauri 2.0 in comments.
  3. Recently packed .msis from Tauri lack files and get falsely reported.
image

https://x.com/yetone/status/1782486009680417097

@yetone yetone closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants