Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnn::Layer::allocate method does not exist anymore in doc #25589

Closed
LaurentBerger opened this issue May 15, 2024 · 0 comments
Closed

dnn::Layer::allocate method does not exist anymore in doc #25589

LaurentBerger opened this issue May 15, 2024 · 0 comments
Assignees
@LaurentBerger
Labels
category: documentation Documentation fix or update
Milestone
4.10.0

Comments

@LaurentBerger
Copy link
Contributor

LaurentBerger commented May 15, 2024 •
edited

Describe the doc issue

image

Each class, derived from Layer, must implement allocate() methods to declare own outputs

allocate method does not exist anymore (since 4.2?)

Fix suggestion

Each class, derived from Layer, must implement forward() to compute outputs.
@LaurentBerger LaurentBerger added the category: documentation Documentation fix or update label May 15, 2024
@asmorkalov asmorkalov changed the title allocate method does not exist anymore in doc dnn::Layer::allocate method does not exist anymore in doc May 15, 2024
@LaurentBerger LaurentBerger mentioned this issue May 15, 2024
Merged
6 tasks
asmorkalov pushed a commit that referenced this issue May 15, 2024
@LaurentBerger
Merge pull request #25591 from LaurentBerger:I25589
76d9f7a 
Remove dnn::layer::allocate in doc #25591

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work #25589 
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
@asmorkalov asmorkalov added this to the 4.10.0 milestone May 15, 2024
klatism pushed a commit to klatism/opencv that referenced this issue May 17, 2024
@LaurentBerger @klatism
Merge pull request opencv#25591 from LaurentBerger:I25589
41b2287 
Remove dnn::layer::allocate in doc opencv#25591

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work opencv#25589 
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LaurentBerger LaurentBerger

Labels
category: documentation Documentation fix or update
Projects
None yet
Milestone
4.10.0
Development

No branches or pull requests
2 participants
@asmorkalov @LaurentBerger