Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider requeue services reconciled with error #361

Open
lwabish opened this issue Oct 7, 2023 · 0 comments
Open

consider requeue services reconciled with error #361

lwabish opened this issue Oct 7, 2023 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@lwabish
Copy link

lwabish commented Oct 7, 2023

Is your feature request related to a problem? Please describe.

In my use case, each node has a dedicated nic for openelb. When those nics are down and some loadbalancer service is created, according to the code logic now, error would occur.

hwAddr, err := a.resolveIP(nodeIP)
if err != nil {
return fmt.Errorf("failed to resolve ip %s, err=%v", nodeIP, err)
}

But when we enable the dedicate nic for openelb, which means the lb services created before should work now. But current Reconcile funtion returns ctrl.Result{}, err, which means the service will not trigger the reconcile function anymore even if edited by user, unless delete openelb-manager pod manually, or delete the service.

Describe the solution you'd like

controller runtime ctrl.Result{} has offered us an option to requeue object with reconcile errors, is it reasonable to use something like ctrl.Result{Requeue: true} ?

Describe alternatives you've considered

Additional context

@lwabish lwabish added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant