Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct code #681

Open
dsuponitskiy opened this issue Feb 27, 2024 · 0 comments
Open

Correct code #681

dsuponitskiy opened this issue Feb 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working cleanup Code cleanup
Milestone

Comments

@dsuponitskiy
Copy link
Collaborator

dsuponitskiy commented Feb 27, 2024

  1. src/binfhe/include/rgsw-cryptoparameters.h: in RingGSWCryptoParams()
    instead of "if ((method == LMKCDEY) & (numAutoKeys == 0))" there should be "if ((method == LMKCDEY) && (numAutoKeys == 0))"
  2. utils/exception.h: make all get functions const for OpenFHEException
  3. FindInVector() is defined in 2 different classes: DiscreteGaussianGeneratorImpl and in BaseSampler.
  4. src/pke/lib/encoding/packedencoding.cpp: bool PackedEncoding::Encode(): "size_t i;" is declared twice outside of the loop in this function. Should not be outside the corresponding loops
  5. Change the name COMPRESSION_LEVEL (constants.h) to Camel case
  6. Add either NOT_SET or INVALID_VALUE to all enums in constants.h
    • Add
      #include "math/hal/basicint.h" // for MAX_MODULUS_SIZE
      to constants.h and remove
      #include "math/math-hal.h"
      #include "lattice/constants-lattice.h"
    • Add #include "lattice/constants-lattice.h" to rlwe-cryptoparameters.h
  7. See if we can replace the __builtin_*() functions with __FILE__, __LINE__ and __FUNCTION__ in OpenFHEException as the functions are available with gcc only
@dsuponitskiy dsuponitskiy added bug Something isn't working cleanup Code cleanup labels Feb 27, 2024
@dsuponitskiy dsuponitskiy added this to the Release 1.2.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cleanup Code cleanup
Projects
None yet
Development

No branches or pull requests

2 participants