Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add more ITs around tiered caching stats #13455

Closed
peteralfonsi opened this issue Apr 29, 2024 · 1 comment · Fixed by #13655
Closed

[Feature Request] Add more ITs around tiered caching stats #13455

peteralfonsi opened this issue Apr 29, 2024 · 1 comment · Fixed by #13655
Assignees
@peteralfonsi
Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance :test Adding or fixing a test v2.15.0 Issues and PRs related to version 2.15.0

Comments

@peteralfonsi
Copy link
Contributor

Is your feature request related to a problem? Please describe

As part of tiered caching we have added a new cache stats API, where individual ICache implementations keep track of their own stats. This approach makes it easier to plug in new cache implementations. We have some ITs around this, but we should add more to make sure there aren't any unknown issues.

Describe the solution you'd like

We should add more ITs combining different cache types with different level aggregations for the stats, across a wider variety of clusters.

Related component

Search:Performance

Describe alternatives you've considered

No response

Additional context

No response
@peteralfonsi peteralfonsi added enhancement Enhancement or improvement to existing feature or request untriaged labels Apr 29, 2024
@peternied peternied added :test Adding or fixing a test and removed untriaged labels May 1, 2024
@peternied
Copy link
Member

[Triage - attendees 1 2 3 4 5 6 7 8]
@peteralfonsi Thanks for creating this issue, looking forward to a pull request.

In the future when creating issues, could you include the specific tests that are missing so its clearer to know when this issue is resolved?

@peteralfonsi peteralfonsi mentioned this issue May 13, 2024
Merged
9 tasks
@getsaurabh02 getsaurabh02 added the v2.15.0 Issues and PRs related to version 2.15.0 label May 28, 2024
@peteralfonsi peteralfonsi mentioned this issue Jun 5, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peteralfonsi peteralfonsi

Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance :test Adding or fixing a test v2.15.0 Issues and PRs related to version 2.15.0
Projects
Performance Roadmap
Status: Done
Search Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tiered Caching] Additional ITs for cache stats peteralfonsi/OpenSearch
3 participants
@peternied @getsaurabh02 @peteralfonsi