Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are the error rate accumulated? #152

Open
OleguerCanal opened this issue Apr 9, 2022 · 5 comments
Open

Why are the error rate accumulated? #152

OleguerCanal opened this issue Apr 9, 2022 · 5 comments
Assignees
Labels
GOOD FIRST ISSUE Good for newcomers QUESTION Further information is requested

Comments

@OleguerCanal
Copy link

OleguerCanal commented Apr 9, 2022

❓ Questions & Help

image

Details

Each call of the error rate accumulates the distance and length. Why is that?Is it to have a running average kind of thing?
Why don't you just return the point-wise wer? @upskyy

@upskyy upskyy self-assigned this Apr 11, 2022
@upskyy upskyy added the QUESTION Further information is requested label Apr 11, 2022
@upskyy
Copy link
Member

upskyy commented Apr 11, 2022

@OleguerCanal We did so because it's good to understand the tendency when it's accumulated as a whole. Is there a reason why you want to do point-wise wer?

@OleguerCanal
Copy link
Author

This makes sense but if using wandb or tensorboard it can already be smoothed like this right?

I'm saying because I was training an architecture with a ctc head and an attn head and wanted to compare the wers of each one. Since I used the same instance of wer_estimator, the values got mixed without me knowing

@sooftware
Copy link
Member

Hi @OleguerCanal! Thank you for your good opinion!
I recycled the code that I made before, so I made it like this.
@upskyy As @OleguerCanal said, why don't we add a way to show the ER for each batch? Let's add this as an option.
--error_rate_logging: accumulate, batch like this?

@OleguerCanal
Copy link
Author

I like this solution @sooftware ! 👍

@sooftware sooftware added the GOOD FIRST ISSUE Good for newcomers label Apr 11, 2022
@sooftware
Copy link
Member

sooftware commented Apr 11, 2022

I think batch would be good as the default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GOOD FIRST ISSUE Good for newcomers QUESTION Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants