Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] Avoid printing mbind errno message to stderr #23874

Merged
merged 2 commits into from Apr 16, 2024
Merged

[CPU] Avoid printing mbind errno message to stderr #23874

merged 2 commits into from Apr 16, 2024

Conversation

EgorDuplensky
Copy link
Contributor

@EgorDuplensky EgorDuplensky commented Apr 4, 2024 •
edited by ilya-lavrenov

Details:

  • If a process lacks CAP_SYS_NICE capability, mbind fails with an error "Operation not permitted". We should either ignore the result (just log) or throw an exception. Also, as an option, we could check if CAP_SYS_NICE is set before performing any mbind related logic.
  • For now just log to the debug

Issues:

@EgorDuplensky EgorDuplensky requested review from a team as code owners April 4, 2024 15:54
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Apr 4, 2024
@EgorDuplensky EgorDuplensky force-pushed the avoid_printing_errno_msg_to_stderr branch from b5c0f42 to e2bdf92 Compare April 4, 2024 15:59
@EgorDuplensky
Copy link
Contributor Author

@sunxiaoxia2022 @wangleis FYI

@xczhai xczhai self-requested a review April 7, 2024 05:28
xczhai
xczhai approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@xczhai xczhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it should be dumped to debug info.

@EgorDuplensky
Copy link
Contributor Author

@maxnick Could you please take a look?

@maxnick maxnick added this to the 2024.2 milestone Apr 11, 2024
@EgorDuplensky EgorDuplensky force-pushed the avoid_printing_errno_msg_to_stderr branch from e2bdf92 to 615ece4 Compare April 15, 2024 16:23
@maxnick maxnick added this pull request to the merge queue Apr 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2024
@maxnick maxnick added this pull request to the merge queue Apr 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2024
@maxnick maxnick added this pull request to the merge queue Apr 16, 2024
Merged via the queue into openvinotoolkit:master with commit 6e961cd Apr 16, 2024
109 checks passed
@maxnick maxnick deleted the avoid_printing_errno_msg_to_stderr branch April 16, 2024 17:04
alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024
@EgorDuplensky @alvoron
[CPU] Avoid printing mbind errno message to stderr (openvinotoolkit#2…
29ab4bb 
…3874)

### Details:
- If a process lacks CAP_SYS_NICE capability, mbind fails with an error
"Operation not permitted". We should either ignore the result (just log)
or throw an exception. Also, as an option, we could check if
CAP_SYS_NICE is set before performing any mbind related logic.
 - For now just log to the debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangleis wangleis wangleis approved these changes

@maxnick maxnick maxnick approved these changes

@sunxiaoxia2022 sunxiaoxia2022 sunxiaoxia2022 approved these changes

@xczhai xczhai xczhai approved these changes

Assignees

@dmitry-gorokhov dmitry-gorokhov

@wangleis wangleis

@maxnick maxnick

Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
2024.2
Development

Successfully merging this pull request may close these issues.

[Bug]: mbind failed: Operation not permitted
6 participants
@EgorDuplensky @wangleis @maxnick @sunxiaoxia2022 @xczhai @dmitry-gorokhov