Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for IsInf operation #24419

Open
eshoguli opened this issue May 8, 2024 · 3 comments · May be fixed by #24471
Open

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for IsInf operation #24419

eshoguli opened this issue May 8, 2024 · 3 comments · May be fixed by #24471
Assignees
Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers no_stale Do not mark as stale platform: arm OpenVINO on ARM / ARM64

Comments

@eshoguli
Copy link
Contributor

eshoguli commented May 8, 2024

Context

JIT Emitters are part of code generation feature (a.k.a. tensor compiler) that automatically produces highly-efficient optimized fused subgraph binary code. Each emitter implements specific operation from low level OpenVINO dialect.

Prerequisites

Recommended to use ARM CPU based platform for development (e.g. Mac, Raspberry Pi etc). Emulators (e.g. QEMU) is still an option, but not that convenient, especially for final performance evaluation.

What needs to be done?

Before emitter implementation, please, modify tests to be sure that deveoped functionality is covered by test:

Tests

Tests are disabled in default build, so ensure to add -DENABLE_TESTS=ON into cmake command.

GoogleTest is used for testing. CPU functional test target is ov_cpu_func_tests. You can use two GoogleTest filters for element-wise and activation operations:

  • for element-wise operations:
./bin/[platform]/[build_type]/ov_cpu_func_tests --gtest_filter="*smoke*Eltwise*"
  • for activations:
./bin/[platform]/[build_type]/ov_cpu_func_tests --gtest_filter="*smoke*Activation*"

Example Pull Requests

Resources

Contact points

@eshoguli, @dmitry-gorokhov

Ticket

CVS-140724

@eshoguli eshoguli added good first issue Good for newcomers no_stale Do not mark as stale category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64 labels May 8, 2024
@inbasperu
Copy link
Contributor

.take

Copy link
Contributor

github-actions bot commented May 9, 2024

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@inbasperu
Copy link
Contributor

Hello @eshoguli, @dmitry-gorokhov,

I have implemented the IsInf JIT emitter for the ARM64 SIMD platform. The work is detailed in this PR: #24471

It would be great if you could review it and let me know if any further adjustments are needed.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers no_stale Do not mark as stale platform: arm OpenVINO on ARM / ARM64
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

2 participants