package review

[margauxgo]

Hi @larnsce @mianzg could one of you please review this package?

[larnsce]

Thanks, @margauxgo. I will take that over.

[larnsce]

I already had a brief look. You have been very quick with this package, well done.

One item I noticed, which I suggest you rework is your data import and then the separation of columns in your `data_processing.R:

wsabrazil/data-raw/data_processing.R

Line 11 in 3aff4e2

data_in <- read_csv("data-raw/PA_census_data.csv") |>

You have a semicolon ; separated file here. You can use read_csv2() or read_delim(delim = ";") to read the file properly. Then you don't need to separate the columns.

[margauxgo]

Thanks @larnsce, I just modified that.

Concerning the data format, I am still debating wether to pivot the dataset to long format to group the variables piped_water, well_spring_water, stored_rainwater and other_water_source into a variable named water_supply, the variables bathroom_sewerage, bathroom_septic_tank and bathroom_cesspit into a variable named sanitation and the variables bathroom_ditch, bathroom_waterbodies and bathroom_other into a variable named wastewater, or to keep it in wide format.

For now, I illustrated how to pivot it for simpler analysis in the example and kept it in wide format otherwise.

What do you think?

[mianzg]

Thanks @larnsce, I just modified that.

Concerning the data format, I am still debating wether to pivot the dataset to long format to group the variables piped_water, well_spring_water, stored_rainwater and other_water_source into a variable named water_supply, the variables bathroom_sewerage, bathroom_septic_tank and bathroom_cesspit into a variable named sanitation and the variables bathroom_ditch, bathroom_waterbodies and bathroom_other into a variable named wastewater, or to keep it in wide format.

For now, I illustrated how to pivot it for simpler analysis in the example and kept it in wide format otherwise.

What do you think?

I also had a similar debate: openwashdata/whatawaste#2

I would for now keep it in wide format for now.

[mianzg]

1. Please refine the 1st figure with more information, e.g. title, x/y-axis label
2. What is the references directory?