Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: add yurtappset validation webhook and default nodepool label #1987

Conversation

vie-serendipity
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

  1. Add yurtappset validation webhook
  2. Support {{nodepool-name}} for batch modifying
  3. Support statefulset

Which issue(s) this PR fixes:

Fixes #1970 #1969 #1966

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

other Note

vie-serendipity and others added 26 commits March 6, 2024 16:57
…a1 yurtappset

fix: add statefulset manager

fix: create function of statefulset manager
openyurtio#1974)

* fix: deployment render should only mutate workloads created by yurtappset v1alpha1
Bumps [github.com/go-resty/resty/v2](https://github.com/go-resty/resty) from 2.7.0 to 2.12.0.
- [Release notes](https://github.com/go-resty/resty/releases)
- [Commits](go-resty/resty@v2.7.0...v2.12.0)

---
updated-dependencies:
- dependency-name: github.com/go-resty/resty/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@vie-serendipity vie-serendipity changed the title [WIP] Add yurtappset validation webhook and default nodepool label [WIP] feat: add yurtappset validation webhook and default nodepool label Mar 20, 2024
@rambohe-ch
Copy link
Member

@vie-serendipity please fix the conflicts.

@vie-serendipity
Copy link
Contributor Author

@rambohe-ch Because the commits in the pull request are very messy. I open a new pull request. https://github.com/openyurtio/openyurt/pull/1997

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Enhancement about tweaks of yurtappset
4 participants