Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] yurt-iot-dock v1.4.1 doesn't match the edgex v3.1.0 #1992

Open
24sama opened this issue Mar 25, 2024 · 6 comments
Open

[BUG] yurt-iot-dock v1.4.1 doesn't match the edgex v3.1.0 #1992

24sama opened this issue Mar 25, 2024 · 6 comments
Labels
kind/bug kind/bug

Comments

@24sama
Copy link

24sama commented Mar 25, 2024

What happened:
When I deploy yurt-iot-dock v1.4.1, I fount it doesn't match the edgex v3.1.0.

image

And I see the code logic of the release-v1.4 branch and v1.4.1 tag, which all don't contain the "napa".

func (ep *EdgexDock) CreateDeviceClient() (clients.DeviceInterface, error) {
switch ep.Version {
case "minnesota", "levski", "kamakura", "jakarta":
return edgexcliv2.NewEdgexDeviceClient(ep.CoreMetadataAddr, ep.CoreCommandAddr), nil
default:
return nil, fmt.Errorf("unsupported Edgex version: %v", ep.Version)
}
}
func (ep *EdgexDock) CreateDeviceProfileClient() (clients.DeviceProfileInterface, error) {
switch ep.Version {
case "minnesota", "levski", "kamakura", "jakarta":
return edgexcliv2.NewEdgexDeviceProfile(ep.CoreMetadataAddr), nil
default:
return nil, fmt.Errorf("unsupported Edgex version: %v", ep.Version)
}
}
func (ep *EdgexDock) CreateDeviceServiceClient() (clients.DeviceServiceInterface, error) {
switch ep.Version {
case "minnesota", "levski", "kamakura", "jakarta":
return edgexcliv2.NewEdgexDeviceServiceClient(ep.CoreMetadataAddr), nil
default:
return nil, fmt.Errorf("unsupported Edgex version: %v", ep.Version)
}
}

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • OpenYurt version:
  • Kubernetes version (use kubectl version):
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

others

/kind bug

@24sama 24sama added the kind/bug kind/bug label Mar 25, 2024
@24sama 24sama changed the title [BUG] [BUG] yurt-iot-duck v1.4.1 doesn't match the edgex v3.1.0 Mar 25, 2024
@24sama 24sama changed the title [BUG] yurt-iot-duck v1.4.1 doesn't match the edgex v3.1.0 [BUG] yurt-iot-dock v1.4.1 doesn't match the edgex v3.1.0 Mar 25, 2024
@rambohe-ch
Copy link
Member

@zyjhtangtang @LavenderQAQ PTAL

@LavenderQAQ
Copy link
Member

@24sama Thank you for raising this issue. In fact, this should already be supported. We just need to add the napa case. Could you submit a pr to help fix this?

@24sama
Copy link
Author

24sama commented Mar 26, 2024

@LavenderQAQ Got it, and I found this PR:
#1850
Maybe we can cherry-pick this PR into release-v1.4

Another question, if I build the yurt-iot-dock from release-v1.4 source code, Is it will miss some feature or bugfix PR which is compared to official v1.4.1 version?

@LavenderQAQ
Copy link
Member

@24sama When 1.4 was released, there was no napa release yet. This is a more recent version that we support, and we can fix it directly on master.

@24sama
Copy link
Author

24sama commented Mar 26, 2024

Thanks @LavenderQAQ , so it means there is only a master branch that supports napa release. And how soon is the official plan to release a new version with napa support? Just like this, we can checkout a new release branch that includes all master PR, and can build it from the release branch.

@rambohe-ch
Copy link
Member

Thanks @LavenderQAQ , so it means there is only a master branch that supports napa release. And how soon is the official plan to release a new version with napa support? Just like this, we can checkout a new release branch that includes all master PR, and can build it from the release branch.

@24sama we plan to release OpenYurt v1.5 in the middle of April, please stay in tune.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug kind/bug
Projects
None yet
Development

No branches or pull requests

3 participants