Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO(bhenning) in core/domain/exp_domain_test.py: The validation tests below should be split into separate unit tests. Also, all validation errors should be covered in the tests. #20307

Closed
poloreoyeniji opened this issue May 14, 2024 · 1 comment

Comments

@poloreoyeniji
Copy link

Split the validation tests in ‘test_validation’ and cover all errors. The current ‘test_validation’ function contains multiple validation checks for explorations. This makes the test logic complex and difficult to maintain. Not all potential validation errors might be covered in this single test.

@seanlip
Copy link
Member

seanlip commented May 29, 2024

Closing because this doesn't follow expected issue-filing conventions. Please see e.g. #20337 for how to handle this.

@seanlip seanlip closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants