Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO(sll) in core/templates/pages/exploration-editor-page/modal-templates/exploration-metadata-modal.component.ts: Get rid of the $timeout. #20311

Closed
FaithAbiola opened this issue May 14, 2024 · 1 comment

Comments

@FaithAbiola
Copy link
Contributor

The timeout is currently used because there is a race condition: the saveDisplayedValue() calls above result in autosave calls. These race with the discardDraft() call that will be called when the draft changes entered here are properly saved to the backend.

Refactor the code to remove the need for the $timeout and address the race condition issue.

@FaithAbiola FaithAbiola changed the title TODO(sll) in /exploration-metadata-modal.component.ts: Get rid of the $timeout TODO(sll) in core/templates/pages/exploration-editor-page/modal-templates/exploration-metadata-modal.component.ts: Get rid of the $timeout May 14, 2024
@FaithAbiola FaithAbiola changed the title TODO(sll) in core/templates/pages/exploration-editor-page/modal-templates/exploration-metadata-modal.component.ts: Get rid of the $timeout TODO(sll) in core/templates/pages/exploration-editor-page/modal-templates/exploration-metadata-modal.component.ts: Get rid of the $timeout. May 14, 2024
@seanlip
Copy link
Member

seanlip commented May 26, 2024

Closing as duplicate of #20338.

@seanlip seanlip closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants