Comment on Files in a Pull Request (Beta) Feedback #49954
Replies: 98 comments 50 replies
-
Thank you for adding this feature, I typically leave general comments linked to the bottom line of a file; it'll be much nicer to leave a more general comment. 🙏🏻 |
Beta Was this translation helpful? Give feedback.
-
Love this! This is going to be super useful 🥳 |
Beta Was this translation helpful? Give feedback.
-
Love this direction! Feedback: It seems that leaving a file-level review comment on a deleted file right now shows that comment as Outdated and isn't displayed in the file view, only being visible in the conversation timeline. |
Beta Was this translation helpful? Give feedback.
-
This is super useful, previously I needed to add generic comments mentioning files, now this will point to the exact file 👍 |
Beta Was this translation helpful? Give feedback.
-
I've always wanted this! thank you for adding it! |
Beta Was this translation helpful? Give feedback.
-
This is great! In addition to:
it also enables adding a comment on an empty file that was accidentally committed, which coincidentally I had to work around just a few hours ago, but now I can comment directly on it 🤩 Thanks! |
Beta Was this translation helpful? Give feedback.
-
Nice - thanks for implementing this! |
Beta Was this translation helpful? Give feedback.
-
Awesome! |
Beta Was this translation helpful? Give feedback.
-
Great! 🚀 |
Beta Was this translation helpful? Give feedback.
-
Hurrah! (A related ask: Can we get keyboard shortcuts to initiate a code comment--on a line or a file--when reviewing? Thanks.) |
Beta Was this translation helpful? Give feedback.
-
A nice feature, I was adding comments for the first line of the file before 😭 |
Beta Was this translation helpful? Give feedback.
-
Awesome feature..!!! I just used it on a PR. |
Beta Was this translation helpful? Give feedback.
-
Really nice! Long awaited feature on my end! |
Beta Was this translation helpful? Give feedback.
-
Looks great! until now I either left a comment on the 1st line or in a random place stating this it's not related specifically to this line 🙈 |
Beta Was this translation helpful? Give feedback.
-
Thank you for introducing this feature. 👏 I believe this feature will be especially useful to newly onboarded engineers who need to ramp up quickly. By allowing all previous discussions to be posted as comments in the corresponding files, it will be much easier to understand the business logic involved. |
Beta Was this translation helpful? Give feedback.
-
Since this is in Beta, it'd be nice to be able to suggest File Renaming, I believe there is no such suggestion capability. The suggestion can be similar to Code Change Suggestions, instead the change will suggested for the file name, and the user can commit directly from the Suggestion which renames the file to the suggested one. Thanks for this feature, its really helpful. |
Beta Was this translation helpful? Give feedback.
-
This is a gigantic help for me and my team. Thank you |
Beta Was this translation helpful? Give feedback.
-
Thanks for the great feedback and overwhelming response to this feature! It's now generally available and also now available in GitHub Mobile. |
Beta Was this translation helpful? Give feedback.
-
Bug report on files review -- wrong z-order of "Comment on this file" popup hint: |
Beta Was this translation helpful? Give feedback.
-
Another bug report: wrong text hint on pending comments amount (if you move mouse over the number): |
Beta Was this translation helpful? Give feedback.
-
Today I ran into an issue. If I try to comment on a file while viewing a single commit in a PR, the comment area tries to open, but nothing is displayed. While, on the other hand, if I review all the changes at once, it works as expected. Short video demo: Screen.Recording.2023-05-05.at.9.56.16.AM_compressed.mp4 |
Beta Was this translation helpful? Give feedback.
-
On a related note: check annotations that are addressed to files (line 0) don't show up at the bottom of "Files changed" https://github.com/TWiStErRob/net.twisterrob.cinema/pull/467/files https://github.com/TWiStErRob/net.twisterrob.cinema/pull/467/checks?check_run_id=13881041239 |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
When you leave a comment on a file, it's marked as Anyway, thank you for the feature. |
Beta Was this translation helpful? Give feedback.
-
The PR view of a comment on a renamed file doesn't include the old filename, which is really problematic as I'm often commenting to show how a filename changed, consider dotnet/fsharp#16212 (comment): Here's the files view which seems to have lost the comment: |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
Is it possible to leave file-level comments on a Pull Request when viewing/managing that PR from the context of Github's browser-based code editor (can be opened by pressing |
Beta Was this translation helpful? Give feedback.
-
Commenting on a file in a pull request (not just a specific line) is
available in public betanow generally available.This feature lets you comment on deleted, binary (including images), and renamed files in a pull request. You can also comment generally about a changed code file without having to attach the comment to a specific line.
Learn more about commenting on a pull request (docss) or see the beta changelog for more details.
Known issues
GitHub Mobile support is coming🎉 SHIPPED 🎉API support is coming🎉 SHIPPED 🎉Tell us what you think
Let us know if you run into problems, have questions, have a request, or just wanna say how useful (or not) this feature is!
Beta Was this translation helpful? Give feedback.
All reactions