Code review doesn't allow commenting on commit messages #56449
Replies: 3 comments
-
Hi, I wouldn't categorize this as a bug per se but it is a crucial feature that is currently lacking. This is probably one of the reason why some contributors on github don't care about their git commit messages. They stuff everything into the pull request description and leave the git history aside. |
Beta Was this translation helpful? Give feedback.
-
Yes, allowing commenting on commit messages is what my team needs we value the commit message in our workflow. |
Beta Was this translation helpful? Give feedback.
-
In case it interests anyone, here is the Gitlab counterpart. |
Beta Was this translation helpful? Give feedback.
-
Select Topic Area
Bug
Body
A large open source project to which I contribute recently migrated from Gerrit to GitHub.
There are several things that are significantly more challenging or inconvenient now as a result, but I just encountered one that seems insurmountable.
In Gerrit, we can easily comment on the commit message just as with any other changed file.
GitHub does not seem to have any way of doing this. I would like to comment on specific lines on the commit message, and am unable to do so.
This is a major bug and deficiency in the code review functionality. There is no elegant workaround for this. Reviewers MUST be able to comment on commit messages as with any other code. This is essential for requesting changes to the commit message, with an inline comment in the relevant place.
Beta Was this translation helpful? Give feedback.
All reactions