Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency cycle between osquery_core and plugins_config_parsers #8252

Open
Smjert opened this issue Jan 22, 2024 · 0 comments
Open

Fix dependency cycle between osquery_core and plugins_config_parsers #8252

Smjert opened this issue Jan 22, 2024 · 0 comments

Comments

@Smjert
Copy link
Member

Smjert commented Jan 22, 2024

The osquery_core library depends on plugins_config_parsers in the addLegacyFieldsAndDecorations, because it has to access the flag FLAGS_decorations_top_level, which is defined in plugins_config_parsers.
Vice versa plugins_config_parsers (as most of the rest of the code in osquery) depends on osquery_core.

A first hacky fix could be to not use the FLAGS_decorations_top_level variable to access that information (which is also not thread safe!), but use the gflag functions to get the flag by name instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant