add pending state to ATC tables to avoid duplicate sql attaches #8324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #8233 and adds an alternate fix to avoid duplicate ATC table registrations. The idea is to add a pending state to the ATC table that ensures it is skipped in the
attachVirtualTables
function (called during database initialization) in favor of being added by the SQL plugin's "attach" command.After the table is registered successfully, it is no longer set to pending, so it is included as expected when the database is reloaded or an ephemeral non-primary instance created.
Fixes: #8323
Manually tested the key scenarios: