Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate seasonality periods into seperate objects #1152

Open
ourownstory opened this issue Feb 8, 2023 · 2 comments
Open

Seperate seasonality periods into seperate objects #1152

ourownstory opened this issue Feb 8, 2023 · 2 comments
Assignees
Labels
P2 Medium priority task Tasks (not an epic, not a bug)

Comments

@ourownstory
Copy link
Owner

          In a future PR, we may want to have a seasonality object per period instantiated - thus a class should not need know the `num_seasonalities_modelled`.

Originally posted by @ourownstory in #1141 (comment)

@ourownstory ourownstory added this to the Release 0.5.3 milestone Feb 8, 2023
@karl-richter karl-richter removed this from the Release 0.5.3 milestone Feb 17, 2023
@ourownstory ourownstory added the task Tasks (not an epic, not a bug) label Feb 24, 2023
@christymctse christymctse added epic Epic issue, like a group of issues for bigger tasks task Tasks (not an epic, not a bug) and removed task Tasks (not an epic, not a bug) epic Epic issue, like a group of issues for bigger tasks labels Feb 24, 2023
@noxan noxan added the P2 Medium priority label Feb 24, 2023
@noxan
Copy link
Collaborator

noxan commented Feb 24, 2023

A bit related to the API refactoring we were discussing

@noxan noxan self-assigned this Feb 24, 2023
@noxan
Copy link
Collaborator

noxan commented Apr 7, 2023

@LeonieFreisinger @leoniewgnr I see this as a part of #1007 (or at least closely related) and the API refactoring as previously mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium priority task Tasks (not an epic, not a bug)
Projects
Status: Modularity
Development

No branches or pull requests

4 participants