Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unsupported Picmo emoji picker with something else #3598

Open
gabek opened this issue Feb 24, 2024 · 4 comments
Open

Replace unsupported Picmo emoji picker with something else #3598

gabek opened this issue Feb 24, 2024 · 4 comments
Assignees
Labels
dependencies Pull requests that update a dependency file Web frontend Issues dealing with the web site

Comments

@gabek
Copy link
Member

gabek commented Feb 24, 2024

Share your bug report, feature request, or comment.

Unfortunately, our emoji picker, Picmo, is no longer supported. While Picmo isn't going to stop working out of nowhere immediately, it may stop working due to changes in React or some other dependency at some point down the road. I'd rather us remove this library on our schedule instead of somebody else's schedule.

See EmojiPicker.tsx for our implementation of the emoji picker.

I don't have a preference on what we replace it with, but if anybody has recommendations, feel free to suggest them here!

@gabek gabek added Web frontend Issues dealing with the web site dependencies Pull requests that update a dependency file labels Feb 24, 2024
@dev265545
Copy link
Contributor

dev265545 commented Feb 25, 2024

You can look at Emoji-mart -> https://github.com/missive/emoji-mart

GitHub
🏪 One component to pick them all. Contribute to missive/emoji-mart development by creating an account on GitHub.

@DarkFalc0n
Copy link
Contributor

Is this issue being addressed currently? I was going through emoji mart earlier, and I think I can handle this migration.

@gabek
Copy link
Member Author

gabek commented Feb 25, 2024

@DarkFalc0n It's not yet! I truly appreciate you offering to look into it! I'm not sure how emoji mart handles custom emoji, but feel free to throw out any thoughts if you run into anything there. Thank you so much!

@DarkFalc0n
Copy link
Contributor

Hey @gabek sorry for the late update,
I tried emojimart on a test project and it works well. Also the way to add custom emojis is pretty straightforward,
the <Picker /> element can take a custom prop, which is declared as follows:

const custom = [
  {
    id: "github",
    name: "GitHub",
    emojis: [
      {
        id: "octocat",
        name: "Octocat",
        keywords: ["github"],
        skins: [
          {
            src: "https://github.githubassets.com/assets/GitHub-Mark-ea2971cee799.png",
          },
        ],
      },
    ],
  },
];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Web frontend Issues dealing with the web site
Projects
None yet
Development

No branches or pull requests

3 participants