Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-Mail Validation fails on /admin123 login #1126

Open
ip6li opened this issue Jul 30, 2023 · 1 comment
Open

E-Mail Validation fails on /admin123 login #1126

ip6li opened this issue Jul 30, 2023 · 1 comment

Comments

@ip6li
Copy link

ip6li commented Jul 30, 2023

Describe the bug

After entering login data for admin123 message "Your Email must be a valid email address." appears, but e-mail address is valid.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://ph7.example.com/admin123/main/login
  2. Enter admins e-mail, username and password
  3. See error

Expected Behavior

e-mail address should validate

Screenshots / Screencasts

ph7-screenshot

Workaround

To get this working, I considered following workaround:

--- Validate.class.php.ORIG	2023-07-30 04:29:28.602137792 +0000
+++ Validate.class.php	2023-07-30 04:24:20.233319333 +0000
@@ -272,6 +272,7 @@
     public function email($sEmail, $bRealHost = false)
     {
 
+        return true;
         $sEmail = filter_var($sEmail, FILTER_SANITIZE_EMAIL);
 
         if ($bRealHost) {
@pH-7
Copy link
Member

pH-7 commented Aug 7, 2023

Hi @ip6li

Thank you for raising this concern 🙂 Returning true will completely disable the email validation check. We don't want this.

Could you share the pattern format of the email you have used? FYI, the email functions use the native PHP function filter_var with FILTER_VALIDATE_EMAIL, as follow ($sEmail, FILTER_VALIDATE_EMAIL) to determine if an email is valid or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants