New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change plugin imports to from papercast.types.plugin import Class #10

Open

papercast-dev opened this issue Apr 20, 2023 · 0 comments

Owner

papercast-dev commented Apr 20, 2023 •

edited

We currently import stuff from plugins with

from papercast.processors import ArxivProcessor, SemanticScholarProcessor

This would change to

from papercast.processors.arxiv import ArxivProcessor
from papercast.processors.semanticscholar import SemanticScholarProcessor

Pros:

Possibility to simplify static code analysis?
- Take a look at processors/init.py and see whether this would actually simplify anything. See Enable code analysis for plugins #9
Maybe make it clearer where each object is coming from

Cons:

Import statement is not as clean, importing types from several locations take up multiple lines

papercast-dev mentioned this issue

Enable code analysis for plugins #9

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment