Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReceiptFileClient generic over codec #8145

Open
emhane opened this issue May 7, 2024 · 0 comments
Open

ReceiptFileClient generic over codec #8145

emhane opened this issue May 7, 2024 · 0 comments
Labels
C-debt A section of code is hard to understand or change

Comments

@emhane
Copy link
Member

emhane commented May 7, 2024

Describe the feature

Make ReceiptFileClient generic over codec. This way it can be used for importing the standard receipts RLP encoding. Rn it is fixed to HackReceiptCodec, a special codec used on testinprod-io/op-geth#1.

reth/crates/net/downloaders/src/receipt_file_client.rs

Line 41 in 0ad9c78

FramedRead::with_capacity(reader, HackReceiptFileCodec, num_bytes as usize);

Probably best way to do this, is add an extension trait, FromReceiptReader, that has FromReader as supertrait.

Additional context

No response
@emhane emhane added the C-debt A section of code is hard to understand or change label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-debt A section of code is hard to understand or change
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emhane