refactor: extract init from node-core #8373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlawt
force-pushed
the
issue-8171-node-core
branch
from
8efb414
to
5cf3dd6
Compare
|
ah cool, I was looking for this actually. |
mattsse
requested changes
May 23, 2024
crates/db-common/src/lib.rs
Outdated
There was a problem hiding this comment.
this needs the regular lib.rs header including the cfg for unused crates
There was a problem hiding this comment.
done! also cleaned up the unused dependencies
wlawt
force-pushed
the
issue-8171-node-core
branch
from
42d0916
to
ed3ae98
Compare
wlawt
requested review from
rkrasiuk,
rakita,
joshieDo,
shekhirin and
emhane
as code owners
wlawt
force-pushed
the
issue-8171-node-core
branch
2 times, most recently
from
92bc01a
to
42d0916
Compare
wlawt
force-pushed
the
issue-8171-node-core
branch
from
42d0916
to
08db132
Compare
|
how can i fix the fmt issue? when i run the |
mattsse
requested changes
May 24, 2024
Comment on lines
-38
to
-42
| reth-trie.workspace = true | ||
| reth-consensus-common.workspace = true | ||
| reth-beacon-consensus.workspace = true | ||
| reth-etl.workspace = true | ||
| reth-codecs.workspace = true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8171 .
Overview
Introduces the
reth-db-commoncrate and movesnode-core/init.rsinto this new crate.Test Plan