Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI check that reth-primitives compiles to RISC-V #8176

Open
puma314 opened this issue May 9, 2024 · 1 comment
Open

Add CI check that reth-primitives compiles to RISC-V #8176

puma314 opened this issue May 9, 2024 · 1 comment
Labels
C-enhancement New feature or request

Comments

@puma314
Copy link

puma314 commented May 9, 2024

Describe the feature

RISC-V is an important target for zkVMs, such as SP1, Risc0, JOLT and others, which prove the execution of RISC-V bytecode in a zero-knowledge proof. reth-primitives is an important crate that is meant to be minimal in dependencies and should be compilable to the RISC-V target for use in all zkVMs.

While PRs in the past have been merged in to ensure that reth-primitives can compile to RISC-V, without a CI check to ensure this compilation is possible, networking dependencies (or other incompatible dependencies) sneak into the reth-primitives crate.

It would be great to add a CI check to ensure this crate (and others that can be added in the future) with appropriate features enabled can be compiled to RISC-V.

h/t to @preston-evans98 for suggesting this issue.

Additional context

No response

@puma314 puma314 added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels May 9, 2024
@preston-evans98
Copy link

preston-evans98 commented May 9, 2024

This would be super useful for us at Sovereign Labs!

Note that all of the platforms referenced in the original issue require a 32-bit RISC-V architecture.

Our preferred target for the check is the official riscv32im-risc0-zkvm, which captures the constraints of zk execution environments (i.e. limited std support with no networking).

@DaniPopes DaniPopes removed the S-needs-triage This issue needs to be labelled label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants