Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DNS resolution for bootnode URL #8187

Open
Rjected opened this issue May 9, 2024 · 1 comment · May be fixed by #8188
Open

Support DNS resolution for bootnode URL #8187

Rjected opened this issue May 9, 2024 · 1 comment · May be fixed by #8188
Assignees
@Rjected
Labels
A-discv4 Related to discv4 discovery A-discv5 Related to discv5 discovery C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@Rjected
Copy link
Member

Rjected commented May 9, 2024

Geth parses enode addrs here:
https://github.com/ethereum/go-ethereum/blob/74edc9386495f0ff44d68bf6e237a69f27021144/p2p/enode/urlv4.go#L72-L81

which does resolution here:
https://github.com/ethereum/go-ethereum/blob/74edc9386495f0ff44d68bf6e237a69f27021144/p2p/enode/urlv4.go#L129-L137

We should support DNS resolution for bootnode enode URLs, although we should:

  • first parse, with a string fallback in case it is a domain and not an IP
  • attempt to resolve the string fallback later, with a timeout
@Rjected Rjected added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-discv4 Related to discv4 discovery A-discv5 Related to discv5 discovery labels May 9, 2024
@Rjected Rjected linked a pull request May 9, 2024 that will close this issue
Draft
@sergerad
Copy link
Contributor

@Rjected did you want any help with your PR for this? Happy to help, have worked on similar stack in geth.

@Rjected Rjected self-assigned this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rjected Rjected

Labels
A-discv4 Related to discv4 discovery A-discv5 Related to discv5 discovery C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: resolve domains in enode strings paradigmxyz/reth
2 participants
@Rjected @sergerad