Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficiency improvment by using map instead of vector to keeping children in PathTrie #197

Open
panmareksadowski opened this issue Feb 9, 2022 · 0 comments

Comments

@panmareksadowski
Copy link

Hi,

I think using std::unordered_map<int, PathTrie*> instead of std::vector<std::pair<int, PathTrie*>> could increase efficiency of adding and removing nodes from PathTrie.

Map should be specially more efficient when using larger alphabet(e.g. bigrams instead of letters).

Is there any reason why using vector to keeping node children is better than using unordered_map or map?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant