Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request/Patch: Allow configuring the volume controls' and signal strength bars' colors. #69

Open
m7a opened this issue Dec 1, 2020 · 3 comments

Comments

@m7a
Copy link

m7a commented Dec 1, 2020

I find it a little confusing that volume control and signal displays are colored in the same colors. I guess this is only due to personal preference, though. Thus I wonder whether having configurable foreground colors for the individual parts of the bars could be beneficial?

A patch for bf4acb3 acting as a proof-of-concept is attached.
In case it looks good enough, it is of course also possible to apply it; in case it is easier to handle, I can of course alternatively try to open a pull request instead :)

patch-allow-differnet-colors.txt

@patroclos
Copy link
Owner

Interesting idea, although I'm not a big fan of adding more hard to read numeric colors into the configuration.

Also while we're at it, we might as well toss the idea of low,medium and high and just let the user create those distinctions in the config.

@m7a
Copy link
Author

m7a commented Dec 5, 2020

Wrt. hard to read: I think I can come up with an improved version that would use more readable names, it will just take some time :)

Regarding the configuration of the areas: I am not sure how useful this is for a "global" configuration because most likely, the "good signal" area will depend on the actual device in use? But then again, I am not really an audio expert...

@m7a
Copy link
Author

m7a commented Dec 6, 2020

Update: Improved patch to use color names rather than numbers. Now against current dev (ec3a383)
patch-allow-different-colors-2.txt

Another thing that I would love to configure is the unicode characters used for drawing. Reasons: I might want to experiment with using the "large block" characters (e.g. █░▒▓) for signal strengths/loudness and regular ASCII for mute/unmute symbols (as they are not displayed correctly here and I do not want to have Emoji in my terminals anyways :) ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants