Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing more LLM models for Langchain::Assistance #514

Open
mengqing opened this issue Mar 9, 2024 · 2 comments
Open

Allowing more LLM models for Langchain::Assistance #514

mengqing opened this issue Mar 9, 2024 · 2 comments

Comments

@mengqing
Copy link
Contributor

mengqing commented Mar 9, 2024

Currently it only supports OpenAI, and I can see that there's a PR for supporting Gemini #513

Is it better to make it more generic and make it extendable? Eg: be able to just extend a new LLM model without hard coding if conditions in the base class.

A lot of other LLM uses OpenAI standard specifications

@andreibondarev
Copy link
Collaborator

@mengqing Yes, I agree with you. It's best kept to be as generic as possible. Do you have any specific ideas/changes to propose? The current Gemini PR is a rough draft before I've thought about any abstractions at all. I've been thinking about maybe implementing a base/parent class and child classes that override specific methods, constants, etc.

@andreibondarev
Copy link
Collaborator

andreibondarev commented Apr 24, 2024

@mengqing Do you have any thoughts on how it's been implemented thus far in #513?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants