Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty error messages when an attachment isn't found #6246

Open
vixalien opened this issue May 7, 2024 · 0 comments
Open

Pretty error messages when an attachment isn't found #6246

vixalien opened this issue May 7, 2024 · 0 comments
Labels
[possible-bug] Possible bug which hasn't been reproduced yet

Comments

@vixalien
Copy link

vixalien commented May 7, 2024

Link to reproduction

No response

Describe the Bug

When running payload in development, it's sometimes possible that media attachments aren't available on the local disk (because we may be using a production database to check for some issues).

When payload misses an attachment, it throws a wall of text like the follow for each missing file.

@org/admin:dev: [04:08:49] ERROR: Error: ENOENT: no such file or directory, stat '/home/alien/sites/rwarri.org/apps/admin/media/payload.jpg'
@org/admin:dev:     at async Object.stat (node:internal/fs/promises:1029:18)
@org/admin:dev:     at async Object.getFile (webpack-internal:///(rsc)/../../node_modules/.pnpm/@payloadcms+next@3.0.0-beta.24_@types+react@18.3.1_graphql@16.8.1_monaco-editor@0.48.0_next@1_dovqcqompostfl6fv5hcmg3soe/node_modules/@payloadcms/next/dist/routes/rest/files/getFile.js:49:23)
@org/admin:dev:     at async eval (webpack-internal:///(rsc)/../../node_modules/.pnpm/@payloadcms+next@3.0.0-beta.24_@types+react@18.3.1_graphql@16.8.1_monaco-editor@0.48.0_next@1_dovqcqompostfl6fv5hcmg3soe/node_modules/@payloadcms/next/dist/routes/rest/index.js:279:39)
@org/admin:dev:     at async /home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/compiled/next-server/app-route.runtime.dev.js:6:53887
@org/admin:dev:     at async e_.execute (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/compiled/next-server/app-route.runtime.dev.js:6:45120)
@org/admin:dev:     at async e_.handle (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/compiled/next-server/app-route.runtime.dev.js:6:55221)
@org/admin:dev:     at async doRender (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/server/base-server.js:1379:42)
@org/admin:dev:     at async responseGenerator (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/server/base-server.js:1593:40)
@org/admin:dev:     at async DevServer.renderToResponseWithComponentsImpl (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/server/base-server.js:1618:28)
@org/admin:dev:     at async DevServer.renderPageComponent (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/server/base-server.js:1931:24)
@org/admin:dev:     at async DevServer.renderToResponseImpl (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/server/base-server.js:1969:32)
@org/admin:dev:     at async DevServer.pipeImpl (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/server/base-server.js:902:25)
@org/admin:dev:     at async NextNodeServer.handleCatchallRenderRequest (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/server/next-server.js:273:17)
@org/admin:dev:     at async DevServer.handleRequestImpl (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/server/base-server.js:798:17)
@org/admin:dev:     at async /home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/server/dev/next-dev-server.js:339:20
@org/admin:dev:     at async Span.traceAsyncFn (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/trace/trace.js:157:20)
@org/admin:dev:     at async DevServer.handleRequest (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/server/dev/next-dev-server.js:336:24)
@org/admin:dev:     at async invokeRender (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/server/lib/router-server.js:174:21)
@org/admin:dev:     at async handleRequest (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/server/lib/router-server.js:353:24)
@org/admin:dev:     at async requestHandlerImpl (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/server/lib/router-server.js:377:13)
@org/admin:dev:     at async Server.requestListener (/home/alien/sites/rwarri.org/node_modules/.pnpm/next@14.3.0-canary.44_react-dom@18.3.1_react@18.3.1/node_modules/next/dist/server/lib/start-server.js:142:13)
@org/admin:dev:  GET /api/media/file/payload.jpg 500 in 9340ms

This makes the logs very much unreadable, and it would be amazing if payload logged something like this instead and moved on:

[PAYLOAD] Could not find local uploaded file: /home/alien/sites/rwarri.org/apps/admin/media/payload.jpg

To Reproduce

Delete one of the payload files in the media file.

Payload Version

3.0.0-beta.24

Adapters and Plugins

No response

@vixalien vixalien added the [possible-bug] Possible bug which hasn't been reproduced yet label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[possible-bug] Possible bug which hasn't been reproduced yet
Projects
None yet
Development

No branches or pull requests

1 participant